Re: dynloader.h missing in prebuilt package for Windows?

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, "Olson, Ken" <Ken(dot)Olson(at)pega(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, "chap(at)anastigmatix(dot)net" <chap(at)anastigmatix(dot)net>
Subject: Re: dynloader.h missing in prebuilt package for Windows?
Date: 2016-01-05 22:47:26
Message-ID: CAB7nPqQrnw4fgV+y3FrDdOgZCJHe+qk8H-3S+NwZ4OGBZzSkxw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jan 5, 2016 at 2:50 PM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> On Tue, Jan 5, 2016 at 2:27 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
>>> The patch would put the buildfarm in red as it is incomplete anyway,
>>> with MSVC what is used instead of dynloader.h is
>>> port/dynloader/win32.h. Instead of this patch I would be incline to
>>> remove the #define stuff with dynloader.h that use WIN32_ONLY_COMPILER
>>> (see for example dfmgr.c) and just copy the header in include/. This
>>> way we use the same header for all platforms.
>>
>> Patch please?
>
> Sure, here you go. Bruce's patch simply forgot to copy the header file
> via Solution.pm, so installation just failed. The change of dfmgr.c is
> actually not mandatory but I think that as long as dynloader.h is
> copied in include/ we had better change that as well, and it makes the
> code cleaner.

By the way, it is definitely wiser to wait for after the release of
9.5.0 to push that or something similar...
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Haribabu Kommi 2016-01-05 23:14:02 Re: Function and view to retrieve WAL receiver status
Previous Message Michael Paquier 2016-01-05 22:46:38 Re: dynloader.h missing in prebuilt package for Windows?