| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Petr Jelinek <petr(at)2ndquadrant(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: XLOG_PARAMETER_CHANGE handling of wal_log_hints |
| Date: | 2015-01-06 23:59:42 |
| Message-ID: | CAB7nPqT9ALQ3e8+CNY1g=ubsKHRSC5UFBh4BSmu12pYHcMzy=Q@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jan 7, 2015 at 4:24 AM, Petr Jelinek <petr(at)2ndquadrant(dot)com> wrote:
> Hi,
>
> when I was fixing how commit_ts handles the XLOG_PARAMETER_CHANGE I noticed
> that for wal_log_hints we assign the value in ControFile to current value
> instead of value that comes from WAL.
>
> ISTM it has just information value so it should not have any practical
> impact, but it looks like a bug anyway so here is simple patch to change
> that.
Right. That's something that should get fixed in 9.4 as well..
ControlFile->track_commit_timestamp = track_commit_timestamp;
The new value of track_commit_timestamp should be taken as well from
xlrec on master btw.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2015-01-07 00:15:11 | Re: Updating copyright notices to 2015 for PGDG |
| Previous Message | Michael Paquier | 2015-01-06 23:56:26 | Re: Updating copyright notices to 2015 for PGDG |