| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Petr Jelinek <petr(at)2ndquadrant(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, xi(at)resolvent(dot)net, PostgreSQL mailing lists <pgsql-bugs(at)postgresql(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [BUGS] BUG #13126: table constraint loses its comment |
| Date: | 2015-07-04 11:45:19 |
| Message-ID: | CAB7nPqT+3iVJs=WB9y4d+R_O2rmRJTCmJxzxYK3bT+0oko0e4A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
On Fri, Jul 3, 2015 at 11:59 PM, Petr Jelinek wrote:
> Well for indexes you don't really need to add the new AT command, as
> IndexStmt has char *idxcomment which it will automatically uses as comment
> if not NULL. While I am not huge fan of the idxcomment it doesn't seem to
> be easy to remove it in the future and it's what transformTableLikeClause
> uses so it might be good to be consistent with that.
Oh, right, I completely missed your point and this field in IndexStmt.
Yes it is better to be consistent in this case and to use it. It makes
as well the code easier to follow.
Btw, regarding the new AT routines, I am getting find of them, it
makes easier to follow which command is added where in the command
queues.
Updated patch attached.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Ensure-COMMENT-persistency-of-indexes-and-constraint.patch | application/x-patch | 18.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Roberto Morelli | 2015-07-04 12:07:49 | Re: BUG #13485: JSONB To recordset not working with CamelCase |
| Previous Message | Michael Paquier | 2015-07-04 02:26:07 | Re: contribcheck and modulescheck of MSVC's vcregress.pl cannot work independently |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2015-07-04 15:02:35 | Re: PostgreSQL 9.5 Alpha 1 build fail with perl 5.22 |
| Previous Message | Michael Paquier | 2015-07-04 11:25:59 | Re: postgresql-9.5alpha1 packaging |