| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, tushar <tushar(dot)ahuja(at)enterprisedb(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_resetwal is broken if run from v10 against older version of PG data directory |
| Date: | 2017-05-29 16:55:26 |
| Message-ID: | CAB7nPqSfMCncBr4JdxKkgwqP5J--6czHMoeYzMAjTnCYqXoJog@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, May 29, 2017 at 9:00 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> So we need to prevent this, not try to make it work. I don't think
> we can insist on a version match in pg_control, because part of the
> point of pg_resetxlog/pg_resetwal is to recover if pg_control is
> unreadable. But I think we could look at PG_VERSION, which is only a
> text file. In bad corruption scenarios, if that somehow got corrupted
> (which seems unlikely since it's never written to post-initdb),
> you could fill in the correct contents by hand and then
> pg_resetxlog/pg_resetwal would run.
Agreed. Shouldn't this be back-patched? PG_CONTROL_VERSION has not
been bumped between 9.4 and 9.5. Attached is a patch for HEAD.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| resetwal-restrict.patch | application/octet-stream | 3.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2017-05-29 17:02:28 | Re: pg_resetwal is broken if run from v10 against older version of PG data directory |
| Previous Message | Jeevan Ladhe | 2017-05-29 16:03:45 | Re: Adding support for Default partition in partitioning |