Re: 64-bit queryId?

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Geoghegan <pg(at)bowt(dot)ie>, "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>, Greg Stark <stark(at)mit(dot)edu>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: 64-bit queryId?
Date: 2017-10-04 14:11:39
Message-ID: CAB7nPqSbZN-o=kNCZy2LKUyiYzGPFHF7Jr7TVpFce7APd7smCg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Oct 4, 2017 at 11:04 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> Not really; dynahash won't merge two keys just because their hash
> codes come out the same. But you're right; that's probably not the
> best way to do it. TBH, why do we even have pgss_hash_fn? It seems
> like using tag_hash would be superior.

Yes, using tag_hash would be just better than any custom formula.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Meskes 2017-10-04 14:23:20 Re: datetime.h defines like PM conflict with external libraries
Previous Message Tom Lane 2017-10-04 14:05:47 Re: datetime.h defines like PM conflict with external libraries