Re: TAP / recovery-test fs-level backups, psql enhancements etc

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Craig Ringer <craig(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: TAP / recovery-test fs-level backups, psql enhancements etc
Date: 2016-03-02 05:22:47
Message-ID: CAB7nPqSZEyYep+xVS+NUw4t9xJ3BVwSw2f7YeWqNLD8ctDTy8Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Mar 2, 2016 at 2:18 PM, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
> Tom Lane wrote:
>> I wrote:
>> > Can't use string ("Test::Builder") as a HASH ref while "strict refs" in use at /usr/share/perl5/Test/Builder.pm line 1798.
>>
>> > The referenced line number is the end of the file,
>>
>> Oh, scratch that; I was looking at the wrong file. Actually,
>> /usr/share/perl5/Test/Builder.pm has
>>
>> sub details {
>> my $self = shift;
>> return @{ $self->{Test_Results} };
>> }
>>
>> and line 1798 is the "return" statement in that. I still lack enough
>> Perl-fu to decipher this, though.
>
> I think it's complaining about being called as a class method. Perhaps
> this would work:
>
> + foreach my $detail (Test::More->builder->details())

Yes, that's the problem. Instead of using details(), summary() is
enough actually. And it is enough to let caller know the failure when
just one test has been found as not passing. See attached.
--
Michael

Attachment Content-Type Size
tap-tmp-failure.patch binary/octet-stream 534 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dilip Kumar 2016-03-02 05:35:26 Re: Move PinBuffer and UnpinBuffer to atomics
Previous Message Alvaro Herrera 2016-03-02 05:18:31 Re: TAP / recovery-test fs-level backups, psql enhancements etc