| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andreas Seltenreich <seltenreich(at)gmx(dot)de>, Piotr Stefaniak <postgres(at)piotr-stefaniak(dot)me>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [sqlsmith] Failed assertion in joinrels.c |
| Date: | 2016-07-27 01:27:02 |
| Message-ID: | CAB7nPqSW-rUBUaECXzi1ZNMpNLdEsDYec=2mWNQ+J4qeGKF2OQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jul 27, 2016 at 5:11 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> Committed with minor kibitizing: you don't need an "else" after a
> statement that transfers control out of the function.
Thanks. Right, I forgot that.
> Shouldn't
> pg_get_function_arguments, pg_get_function_identity_arguments,
> pg_get_function_result, and pg_get_function_arg_default get the same
> treatment?
Changing all of them make sense. Please see attached.
While looking at the series of functions pg_get_*, I have noticed as
well that pg_get_userbyid() returns "unknown (OID=%u)" when it does
not know a user. Perhaps we'd want to change that to NULL for
consistency with the rest?
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| def-funcs-null-rest.patch | application/x-patch | 3.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2016-07-27 01:31:09 | Re: Proposal: revert behavior of IS NULL on row types |
| Previous Message | Peter Eisentraut | 2016-07-27 01:25:33 | Re: to_date_valid() |