Re: Re: [COMMITTERS] pgsql: Use LEFT JOINs in some system views in case referenced row doesn

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Simon Riggs <simon(at)2ndquadrant(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Re: [COMMITTERS] pgsql: Use LEFT JOINs in some system views in case referenced row doesn
Date: 2016-09-12 12:53:05
Message-ID: CAB7nPqSOMwU4=Gzk+HesqUqaOdON0caxm50nOD0Z7CFGO4P0Xg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Mon, Sep 12, 2016 at 9:08 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
>> On Mon, Sep 12, 2016 at 4:19 PM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
>>> Why would we need to backpatch this commit?
>
>> You are right there is no need to get that into 9.6. Sorry for the mistake.
>
> Oh, that's my fault, I'd incorrectly remembered this commit as having been
> further back than it was. HEAD-only is correct so far as fixing
> Fujii-san's original complaint is concerned. However, don't we have the
> problem that am_db_walsender processes will show up in pg_stat_activity
> anyway?

Yes, those show up..

> Do we want to do something about those further back?

Hiding them is not something that we should do, and changing the query
field to show something that we think is helpful may impact existing
applications that rely on the fact that this field is NULL. So I'd
vote for doing nothing.
--
Michael

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Kevin Grittner 2016-09-12 14:30:52 pgsql: Fix recent commit for tab-completion of database template.
Previous Message Tom Lane 2016-09-12 12:08:43 Re: Re: [COMMITTERS] pgsql: Use LEFT JOINs in some system views in case referenced row doesn

Browse pgsql-hackers by date

  From Date Subject
Next Message Vitaly Burovoy 2016-09-12 12:53:06 Re: [REVIEW] Tab Completion for CREATE DATABASE ... TEMPLATE ...
Previous Message Etsuro Fujita 2016-09-12 12:35:35 Re: Push down more full joins in postgres_fdw