Re: Patch to implement pg_current_logfile() function

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: "Karl O(dot) Pinc" <kop(at)meme(dot)com>
Cc: Gilles Darold <gilles(dot)darold(at)dalibo(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Patch to implement pg_current_logfile() function
Date: 2017-01-20 07:09:51
Message-ID: CAB7nPqSMivo2igA_pF26RDwh1JC0ypMuwKeNVEFu7m8b+72Ubw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On Fri, Jan 20, 2017 at 3:29 AM, Karl O. Pinc <kop(at)meme(dot)com> wrote:
> On Thu, 19 Jan 2017 12:12:18 -0300
> Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
>
>> Karl O. Pinc wrote:
>> > On Wed, 18 Jan 2017 19:27:40 -0300
>> > Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
>>
>> > > I thought this part was odd -- I mean, why is SysLogger_Start()
>> > > being called if the collector is not enabled? Turns out we do it
>> > > and return early if not enabled. But not in all cases -- there
>> > > is one callsite in postmaster.c that avoids the call if the
>> > > collector is disabled. That needs to be changed if we want this
>> > > to work reliably.
>> >
>> > Is this an argument for having the current_logfiles always exist
>> > and be empty when there is no in-filesystem logfile? It always felt
>> > to me that the code would be simpler that way.
>>
>> I don't know. I am just saying that you need to patch postmaster.c
>> line 1726 to remove the second arm of the &&.
>
> Gilles,
>
> I'm not available just now. Can you do this or enlist Michael?

Okay I just did it. At the same time the check for ferror is not
necessary as fgets() returns NULL on an error as well so that's dead
code. I have also removed the useless call to FreeFile().
--
Michael

Attachment Content-Type Size
patch_pg_current_logfile-v28.diff text/plain 16.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2017-01-20 07:16:25 Re: pg_hba_file_settings view patch
Previous Message Amit Khandekar 2017-01-20 06:40:44 Re: Too many autovacuum workers spawned during forced auto-vacuum