| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | "Karl O(dot) Pinc" <kop(at)meme(dot)com>, Gilles Darold <gilles(dot)darold(at)dalibo(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Patch to implement pg_current_logfile() function |
| Date: | 2017-01-20 13:11:45 |
| Message-ID: | 20170120131145.lk4lg4mohqhtwhoc@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> diff --git a/src/backend/replication/basebackup.c b/src/backend/replication/basebackup.c
> @@ -148,6 +149,9 @@ static const char *excludeFiles[] =
> /* Skip auto conf temporary file. */
> PG_AUTOCONF_FILENAME ".tmp",
>
> + /* Skip current log file temporary file */
> + LOG_METAINFO_DATAFILE_TMP,
> +
Sorry if this has already been answered, but why are we not also
skipping LOG_METAINFO_DATAFILE itself? I can't see a scenario where
it's useful to have that file in a base backup, since it's very likely
that the log file used when the backup is restored will be different.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2017-01-20 13:14:14 | Re: Patch to implement pg_current_logfile() function |
| Previous Message | Tom Lane | 2017-01-20 13:09:29 | Valgrind-detected bug in partitioning code |