| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Making tab-complete.c easier to maintain |
| Date: | 2016-01-06 00:13:55 |
| Message-ID: | CAB7nPqSLWH7Myit78SX=BQSg1mQ=KQdZ-53pieYgqrYjkKuQgw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jan 6, 2016 at 2:03 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> I wrote:
>> Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
>>> So, here are the commands that still remain with TailMatches to cover
>>> this case, per gram.y:
>>> - CREATE TABLE
>>> - CREATE INDEX
>>> - CREATE VIEW
>>> - GRANT
>>> - CREATE TRIGGER
>>> - CREATE SEQUENCE
>>> New patches are attached.
>
>> I've reviewed and committed the first of these patches.
>
> I've pushed the second patch now. I made a few adjustments --- notably,
> I didn't like the way you'd implemented '*' wildcards, because they
> wouldn't have behaved very sanely in combination with '|'. The case
> doesn't come up in the current set of patterns, but we'll likely want it
> sometime.
Thanks! Let's consider this project as done then. That was a long way to it...
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2016-01-06 00:53:08 | Re: No Issue Tracker - Say it Ain't So! |
| Previous Message | Alexander Korotkov | 2016-01-06 00:13:46 | Re: Optimizer questions |