Re: Extension Templates S03E11

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: David Fetter <david(at)fetter(dot)org>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Boszormenyi Zoltan <zb(at)cybertec(dot)at>, Thom Brown <thom(at)linux(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Extension Templates S03E11
Date: 2013-09-03 03:09:11
Message-ID: CAB7nPqSBzsEjPfmO=2scadEZCWk=NxGh-3L8EoukDJyHieGWFw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Sep 3, 2013 at 4:20 AM, David Fetter <david(at)fetter(dot)org> wrote:
> On Mon, Sep 02, 2013 at 02:32:16AM -0400, Peter Eisentraut wrote:
>> On Thu, 2013-08-29 at 12:16 +0200, Dimitri Fontaine wrote:
>> > Here's v14 of the patch with pg_upgrade support fixed, so that the
>> > automated setup that Peter built is able to have at it!
>>
>> Fails cpluspluscheck:
>>
>> In file included from /tmp/cpluspluscheck.5g2uWw/test.cpp:3:0:
>> ./src/include/commands/template.h:47:8: error: ‘ExtensionControl’ does not name a type
>> ./src/include/commands/template.h:51:8: error: ‘ExtensionControl’ does not name a type
>>
>> I think this actually just means the header does not include all it needs by itself.
>
> Is there some standard set of checks you run on new patches, and are
> the results showing up on, say, the buildfarm or some other CI
> dashboard?
I believe that Peter does all those checks using his own Jenkins environment:
http://pgci.eisentraut.org/jenkins/
For the commit fest patches here you go:
http://pgci.eisentraut.org/jenkins/view/All/job/postgresql_commitfest_world/
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Noah Misch 2013-09-03 03:31:50 Re: dynamic shared memory
Previous Message Peter Geoghegan 2013-09-03 03:00:11 Re: [9.4] Make full_page_writes only settable on server start?