| From: | David Fetter <david(at)fetter(dot)org> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Boszormenyi Zoltan <zb(at)cybertec(dot)at>, Thom Brown <thom(at)linux(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Extension Templates S03E11 |
| Date: | 2013-09-02 19:20:56 |
| Message-ID: | 20130902192056.GD10080@fetter.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Sep 02, 2013 at 02:32:16AM -0400, Peter Eisentraut wrote:
> On Thu, 2013-08-29 at 12:16 +0200, Dimitri Fontaine wrote:
> > Here's v14 of the patch with pg_upgrade support fixed, so that the
> > automated setup that Peter built is able to have at it!
>
> Fails cpluspluscheck:
>
> In file included from /tmp/cpluspluscheck.5g2uWw/test.cpp:3:0:
> ./src/include/commands/template.h:47:8: error: ‘ExtensionControl’ does not name a type
> ./src/include/commands/template.h:51:8: error: ‘ExtensionControl’ does not name a type
>
> I think this actually just means the header does not include all it needs by itself.
Is there some standard set of checks you run on new patches, and are
the results showing up on, say, the buildfarm or some other CI
dashboard?
Cheers,
David.
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter
Skype: davidfetter XMPP: david(dot)fetter(at)gmail(dot)com
iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics
Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fabrízio de Royes Mello | 2013-09-02 20:35:08 | Re: [GENERAL] currval and DISCARD ALL |
| Previous Message | Jeff Davis | 2013-09-02 19:16:37 | Re: Freezing without write I/O |