Re: Hash index creation warning

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, Thom Brown <thom(at)linux(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, David G Johnston <david(dot)g(dot)johnston(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Hash index creation warning
Date: 2015-06-24 07:06:19
Message-ID: CAB7nPqS6Z6SP8aTHNDbEOPpiRTvni2HiX-UqPOfXaDhXf982Sg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jun 24, 2015 at 12:27 AM, Robert Haas wrote:
> I think you should be testing RelationNeedsWAL(), not the
> relpersistence directly. The same point applies for temporary
> indexes.

Indeed. Patch updated attached.
--
Michael

Attachment Content-Type Size
20150624_hash_index_unlogged_v2.patch application/x-patch 2.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2015-06-24 08:43:43 Re: pg_stat_*_columns?
Previous Message Michael Paquier 2015-06-24 06:43:35 Re: pg_rewind failure by file deletion in source server