Re: SSL TAP tests and chmod

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>
Subject: Re: SSL TAP tests and chmod
Date: 2015-06-22 01:50:17
Message-ID: CAB7nPqRvU6yN3OUc2XU9niXx8O=fo6GsjyLj1DGo-WC76QZvrQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jun 19, 2015 at 2:49 PM, Michael Paquier wrote:
> The TAP tests in src/test/ssl are using system() in combination with
> chmod, but perl has a command chmod integrated into it, and it would
> work better on Windows as well.
> The attached patch is aimed at fixing that.

For the sake of the archives, this has been committed by Robert (thanks!):
commit: ca3f43aa48a83013ea50aeee7cd193a5859c4587
author: Robert Haas <rhaas(at)postgresql(dot)org>
date: Fri, 19 Jun 2015 10:46:30 -0400
Change TAP test framework to not rely on having a chmod executable.

This might not work at all on Windows, and is not ever efficient.

Regards,
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2015-06-22 02:02:03 Re: Backpatch src/test/modules to 9.3?
Previous Message Jim Nasby 2015-06-22 00:49:40 Re: pretty bad n_distinct estimate, causing HashAgg OOM on TPC-H