Re: SSL TAP tests and chmod

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: SSL TAP tests and chmod
Date: 2015-06-23 14:23:16
Message-ID: CA+TgmoYMvjyaEZybhM_HQoyR8rGi1x5OqfmcjWiUo6graCQMdw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Jun 21, 2015 at 9:50 PM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> On Fri, Jun 19, 2015 at 2:49 PM, Michael Paquier wrote:
>> The TAP tests in src/test/ssl are using system() in combination with
>> chmod, but perl has a command chmod integrated into it, and it would
>> work better on Windows as well.
>> The attached patch is aimed at fixing that.
>
> For the sake of the archives, this has been committed by Robert (thanks!):
> commit: ca3f43aa48a83013ea50aeee7cd193a5859c4587
> author: Robert Haas <rhaas(at)postgresql(dot)org>
> date: Fri, 19 Jun 2015 10:46:30 -0400
> Change TAP test framework to not rely on having a chmod executable.
>
> This might not work at all on Windows, and is not ever efficient.

Whoops, sorry, I thought I had replied to this thread, but I guess I forgot.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2015-06-23 14:45:07 Re: proposal: row_to_array function
Previous Message Heikki Linnakangas 2015-06-23 14:21:12 Re: pg_rewind failure by file deletion in source server