Skip site navigation (1) Skip section navigation (2)

Re: Re: In-core regression tests for replication, cascading, archiving, PITR, etc.

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Noah Misch <noah(at)leadboat(dot)com>, Amir Rohan <amir(dot)rohan(at)zoho(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)2ndquadrant(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, Greg Smith <gsmith(at)gregsmith(dot)com>
Subject: Re: Re: In-core regression tests for replication, cascading, archiving, PITR, etc.
Date: 2015-12-10 05:52:49
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-hackers
On Thu, Dec 10, 2015 at 6:46 AM, Alvaro Herrera
<alvherre(at)2ndquadrant(dot)com> wrote:
> I've been giving a look. I wonder if we really need that
> as a separate package.  My first thought was that we could have another
> class that inherits from PostgresNode (say RecoveryNode).  But later it
> occured to me that we could have the new functions just be part of
> PostgresNode itself directly; so we would have some new PostgresNode
> methods:
>         $node->enable_streaming
>         $node->enable_restoring
>         $node->enable_archiving


>         $node->wait (your RecoveryTest::wait_for_node; better name for this?)


> and some additional constructors:
>         make_master
>         make_stream_standby
>         make_archive_standby

I have done that a little bit differently. Those are completely
remove, then init() and init_from_backup() are extended with a new set
of parameters to enable archive, streaming or restore on a node.

Which gives the patch attached.

Attachment: 20151210_recovery_suite.patch
Description: binary/octet-stream (23.1 KB)

In response to

pgsql-hackers by date

Next:From: Amit LangoteDate: 2015-12-10 06:10:16
Subject: Re: [PROPOSAL] VACUUM Progress Checker.
Previous:From: Amit KapilaDate: 2015-12-10 05:33:02
Subject: Re: pg_hba_lookup function to get all matching pg_hba.conf entries

Privacy Policy | About PostgreSQL
Copyright © 1996-2018 The PostgreSQL Global Development Group