| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Marko Tiikkaja <marko(at)joh(dot)to> |
| Cc: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Corey Huinker <corey(dot)huinker(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: proposal: function parse_ident |
| Date: | 2016-01-23 15:20:12 |
| Message-ID: | CAB7nPqRn=0rVdS95cGwJospBhTgWm3CZAOuW1v_CtmoO_bWVZQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Jan 23, 2016 at 1:25 AM, Marko Tiikkaja <marko(at)joh(dot)to> wrote:
> Hi Pavel,
>
> Sorry for the lack of review here. I didn't realize I was still the
> reviewer for this after it had been moved to another commitfest.
>
> That said, I think I've exhausted my usefulness here as a reviewer. Marking
> ready for committer.
+ errmsg("identifier contains disallowed chars"),
+ errdetail("string \"%s\" is not valid identifier",
+ text_to_cstring(qualname))));
Perhaps, "identifier contains not allowed character" is better?
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Julien Rouhaud | 2016-01-23 15:31:18 | Re: Removing Functionally Dependent GROUP BY Columns |
| Previous Message | Michael Paquier | 2016-01-23 15:01:24 | Re: silent data loss with ext4 / all current versions |