| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Marko Tiikkaja <marko(at)joh(dot)to>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Corey Huinker <corey(dot)huinker(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: proposal: function parse_ident |
| Date: | 2016-01-23 15:36:15 |
| Message-ID: | 15622.1453563375@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
> On Sat, Jan 23, 2016 at 1:25 AM, Marko Tiikkaja <marko(at)joh(dot)to> wrote:
> + errmsg("identifier contains disallowed chars"),
> + errdetail("string \"%s\" is not valid identifier",
> + text_to_cstring(qualname))));
> Perhaps, "identifier contains not allowed character" is better?
"disallowed" reads better to me. I agree with expanding "chars" to
"characters" though. Also, the errdetail is conveying no actual extra
detail AFAICS. I'd go with something like
errmsg("identifier contains disallowed characters: \"%s\"",
text_to_cstring(qualname)));
regards, tom lane
The errdeta
regards, tom lane
> --
> Michael
> --
> Sent via pgsql-hackers mailing list (pgsql-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-hackers
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2016-01-23 15:39:20 | Re: Removing Functionally Dependent GROUP BY Columns |
| Previous Message | Julien Rouhaud | 2016-01-23 15:31:18 | Re: Removing Functionally Dependent GROUP BY Columns |