Re: Patch to implement pg_current_logfile() function

On Fri, Jan 20, 2017 at 10:11 PM, Alvaro Herrera
<alvherre(at)2ndquadrant(dot)com> wrote:
>> diff --git a/src/backend/replication/basebackup.c b/src/backend/replication/basebackup.c
>
>> @@ -148,6 +149,9 @@ static const char *excludeFiles[] =
>> /* Skip auto conf temporary file. */
>> PG_AUTOCONF_FILENAME ".tmp",
>>
>> + /* Skip current log file temporary file */
>> + LOG_METAINFO_DATAFILE_TMP,
>> +
>
> Sorry if this has already been answered, but why are we not also
> skipping LOG_METAINFO_DATAFILE itself? I can't see a scenario where
> it's useful to have that file in a base backup, since it's very likely
> that the log file used when the backup is restored will be different.

I have done the same remark upthread, and Gilles has pointed out that
it would be useful to get the last log file that was used by a backup.
Including this file represents no harm as well.
--
Michael