| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | "Ideriha, Takeshi" <ideriha(dot)takeshi(at)jp(dot)fujitsu(dot)com> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, Noah Misch <noah(at)leadboat(dot)com> |
| Subject: | Re: Forbid use of LF and CR characters in database and role names |
| Date: | 2016-11-25 07:41:41 |
| Message-ID: | CAB7nPqRi4w-q-8ECxSTv3RzpAnJ_2u=kb14O0WdXDTALmpAcJg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Nov 25, 2016 at 4:02 PM, Ideriha, Takeshi
<ideriha(dot)takeshi(at)jp(dot)fujitsu(dot)com> wrote:
> I applied your fixed patch and new one, and confirmed the applied source passed the tests successfully. And I also checked manually the error messages were emitted successfully when cr/lf are included in dbname or rolename or data_directory.
>
> AFAICT, this patch satisfies the concept discussed before. So I’ve switched this patch “Ready for Committer”.
Thanks for the review, Ideriha-san. (See you next week perhaps?)
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amos Bird | 2016-11-25 07:48:31 | make default TABLESPACE belong to target table. |
| Previous Message | Tomas Vondra | 2016-11-25 07:40:07 | confusing checkpoint_flush_after / bgwriter_flush_after |