Re: Forbid use of LF and CR characters in database and role names

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: "Ideriha, Takeshi" <ideriha(dot)takeshi(at)jp(dot)fujitsu(dot)com>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, Noah Misch <noah(at)leadboat(dot)com>
Subject: Re: Forbid use of LF and CR characters in database and role names
Date: 2016-11-29 04:33:58
Message-ID: CAB7nPqQeDxM5euiVaWw6gYJ0Royjekjs_Rs0JrEBgbe-MJW1Kw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Nov 25, 2016 at 4:41 PM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> On Fri, Nov 25, 2016 at 4:02 PM, Ideriha, Takeshi
> <ideriha(dot)takeshi(at)jp(dot)fujitsu(dot)com> wrote:
>> I applied your fixed patch and new one, and confirmed the applied source passed the tests successfully. And I also checked manually the error messages were emitted successfully when cr/lf are included in dbname or rolename or data_directory.
>>
>> AFAICT, this patch satisfies the concept discussed before. So I’ve switched this patch “Ready for Committer”.
>
> Thanks for the review, Ideriha-san. (See you next week perhaps?)

Patch moved to CF 2017-01.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2016-11-29 04:35:13 Re: Renaming of pg_xlog and pg_clog
Previous Message Michael Paquier 2016-11-29 04:32:59 Re: Quorum commit for multiple synchronous replication.