From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
---|---|
To: | Christian Ullrich <chris(at)chrullrich(dot)net> |
Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: pgsql: Add putenv support for msvcrt from Visual Studio 2013 |
Date: | 2016-09-06 12:36:49 |
Message-ID: | CAB7nPqR_UpjoscmqrRbeGs8qK9B+Uc0ODVH8aikrkh_OgMP__A@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
(Just remembered to remove pgsql-committers here).
On Tue, Sep 6, 2016 at 9:21 PM, Christian Ullrich <chris(at)chrullrich(dot)net> wrote:
> * Michael Paquier wrote:
>
>> On Tue, Sep 6, 2016 at 5:36 PM, Christian Ullrich <chris(at)chrullrich(dot)net>
>> wrote:
>>>
>>> * Michael Paquier wrote:
>
>>>> In order to avoid any problems with the load and unload windows, my
>>>> bet goes for 0001, 0002 and 0003, with the last two patches merged
>>>> together, 0001 being only a set of independent fixes. That's ugly, but
>>>> that looks the safest course of actions. I have rebased/rewritten the
>>>> patches as attached. Thoughts?
>>>
>>>
>>> In lieu of convincing you to drop the entire thing, yes, that looks about
>>> right, except for the BOOL thing.
>>
>>
>> Yes, right. Thanks. Patch 0001 is definitely something that should be
>> applied and backpatched, the CloseHandle() call is buggy. Now 0002 and
>> 0003 are improving things, but there have been no reports regarding
>> problems in this area, so this could just be applied to master I
>> guess. Christian, does that sound right?
>
> Yes.
OK, let's get to the next step of the game and get a committer to look
at this patch.
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Simon Riggs | 2016-09-06 14:41:26 | pgsql: Fix VACUUM_TRUNCATE_LOCK_WAIT_INTERVAL |
Previous Message | Christian Ullrich | 2016-09-06 12:21:00 | Re: pgsql: Add putenv support for msvcrt from Visual Studio 2013 |
From | Date | Subject | |
---|---|---|---|
Next Message | Etsuro Fujita | 2016-09-06 12:45:34 | Push down more UPDATEs/DELETEs in postgres_fdw |
Previous Message | Ashutosh Bapat | 2016-09-06 12:24:54 | Re: Declarative partitioning - another take |