| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Andreas Karlsson <andreas(at)proxel(dot)se> |
| Cc: | Noah Misch <noah(at)leadboat(dot)com>, Andres Freund <andres(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: PATCH: Reducing lock strength of trigger and foreign key DDL |
| Date: | 2015-01-30 06:48:25 |
| Message-ID: | CAB7nPqRRX_fSK5r7DXXfTFGPSZoV+9kgF3ZO8vq1n4-FnWz09Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jan 23, 2015 at 8:55 AM, Andreas Karlsson <andreas(at)proxel(dot)se> wrote:
> On 01/22/2015 10:31 PM, Andreas Karlsson wrote:
>>
>> I agree with this view, and am not sure myself that it is worth lowering
>> the lock level of ALTER TRIGGER RENAME. I have attached a patch without
>> the changes to ALTER TRIGGER and ruleutils.c and also fixes the comment
>> issues noted by Andres.
>
>
> Whops, forgot to include the isolation tests.
Ok, so the deal is to finally reduce the locks to
ShareRowExclusiveLock for the following commands :
- CREATE TRIGGER
- ALTER TABLE ENABLE/DISABLE
- ALTER TABLE ADD CONSTRAINT
Looking at the latest patch, it seems that in
AlterTableGetLockLevel(at)tablecmds(dot)c we ought to put AT_ReAddConstraint,
AT_AddConstraintRecurse and AT_ProcessedConstraint under the same
banner as AT_AddConstraint. Thoughts?
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2015-01-30 06:53:01 | Re: jsonb, unicode escapes and escaped backslashes |
| Previous Message | Tom Lane | 2015-01-30 06:20:36 | Re: jsonb, unicode escapes and escaped backslashes |