| From: | Andreas Karlsson <andreas(at)proxel(dot)se> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Noah Misch <noah(at)leadboat(dot)com>, Andres Freund <andres(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: PATCH: Reducing lock strength of trigger and foreign key DDL |
| Date: | 2015-01-30 18:26:28 |
| Message-ID: | 54CBCCD4.9040609@proxel.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 01/30/2015 07:48 AM, Michael Paquier wrote:
> Ok, so the deal is to finally reduce the locks to
> ShareRowExclusiveLock for the following commands :
> - CREATE TRIGGER
> - ALTER TABLE ENABLE/DISABLE
> - ALTER TABLE ADD CONSTRAINT
Correct. I personally still find this useful enough to justify a patch.
> Looking at the latest patch, it seems that in
> AlterTableGetLockLevel(at)tablecmds(dot)c we ought to put AT_ReAddConstraint,
> AT_AddConstraintRecurse and AT_ProcessedConstraint under the same
> banner as AT_AddConstraint. Thoughts?
Good point. I think moving those would be a good thing even though it is
technically not necessary for AT_AddConstraintRecurse, since that one
should only be related to check constraints.
--
Andreas
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Josh Berkus | 2015-01-30 19:01:45 | Re: tablespaces inside $PGDATA considered harmful |
| Previous Message | jeff.janes | 2015-01-30 18:21:01 |