Re: Incorrect error message in InitializeSessionUserId

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Dmitriy Sarafannikov <d(dot)sarafannikov(at)bk(dot)ru>
Cc: Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Incorrect error message in InitializeSessionUserId
Date: 2016-03-02 06:44:45
Message-ID: CAB7nPqRROEv9cj8iDxrBcx1SnzcgSKYZmRvgxYF+mmT4M1E71w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Mar 1, 2016 at 10:21 PM, Dmitriy Sarafannikov
<d(dot)sarafannikov(at)bk(dot)ru> wrote:
> I have found incorrect error message in InitializeSessionUserId function
> if you try to connect to database by role Oid (for example
> BackgroundWorkerInitializeConnectionByOid).
> If role have no permissions to login, you will see error message like this:
> FATAL: role "(null)" is not permitted to log in
>
> I changed few lines of code and fixed this.
> Patch is attached.
> I want to add this patch to commitfest.
> Any objections?

Not really. That looks like an oversight to me.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message David Fetter 2016-03-02 06:49:26 Re: 2016-03 Commitfest Manager
Previous Message Michael Paquier 2016-03-02 06:34:39 Re: 2016-03 Commitfest Manager