Re: [PATCH] Remove redundant if clause in standbydesc.c

On Fri, Sep 23, 2016 at 6:54 PM, Aleksander Alekseev
<a(dot)alekseev(at)postgrespro(dot)ru> wrote:
>> > Very simple small patch - see attachment.
>>
>> /* not expected, but print something anyway */
>> else if (msg->id == SHAREDINVALRELMAP_ID)
>> - appendStringInfoString(buf, " relmap");
>> - else if (msg->id == SHAREDINVALRELMAP_ID)
>> appendStringInfo(buf, " relmap db %u", msg->rm.dbId);
>>
>> Looking at inval.c, dbId can be InvalidOid.
>
> Frankly I'm not very familiar with this part of code. InvalidOid is just
> zero. Does it create some problem in this case?

Not really but my guess is that the two conditions have been left for
this purpose.
--
Michael