Re: [PATCH] Remove redundant if clause in standbydesc.c

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: Aleksander Alekseev <a(dot)alekseev(at)postgrespro(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Remove redundant if clause in standbydesc.c
Date: 2016-09-23 14:38:57
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
> On Fri, Sep 23, 2016 at 6:54 PM, Aleksander Alekseev
> <a(dot)alekseev(at)postgrespro(dot)ru> wrote:
>>> Very simple small patch - see attachment.
>>> /* not expected, but print something anyway */
>>> else if (msg->id == SHAREDINVALRELMAP_ID)
>>> - appendStringInfoString(buf, " relmap");
>>> - else if (msg->id == SHAREDINVALRELMAP_ID)
>>> appendStringInfo(buf, " relmap db %u", msg->rm.dbId);

> Not really but my guess is that the two conditions have been left for
> this purpose.

I think it's a pretty obvious copy-and-pasteo.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2016-09-23 14:52:40 Re: Speed up Clog Access by increasing CLOG buffers
Previous Message Tom Lane 2016-09-23 14:23:16 Re: Phrase search distance syntax