Re: Incorrect initialization of sentPtr in walsender.c

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Simon Riggs <simon(at)2ndquadrant(dot)com>
Cc: Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Incorrect initialization of sentPtr in walsender.c
Date: 2014-11-18 08:32:26
Message-ID: CAB7nPqRChWTC754e69+Zy2pSr-OvFOFkRjGHhpoACNfp9YWPdQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Oct 16, 2014 at 9:01 PM, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
wrote:

> On Thu, Oct 16, 2014 at 7:09 PM, Simon Riggs <simon(at)2ndquadrant(dot)com>
> wrote:
>
>> I find it confusing that the "Lowest" pointer value is also "Invalid".
>> Valid != Invalid
>>
> In complement to that, note that I mentioned Invalid should be UINT_MAX
> for clarity.
>
Worth noticing that this patch has been marked as returned with feedback.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2014-11-18 08:47:19 Re: WAL format and API changes (9.5)
Previous Message Michael Paquier 2014-11-18 08:28:39 Re: WAL format and API changes (9.5)