| From: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)2ndquadrant(dot)com>, Abhijit Menon-Sen <ams(at)2ndquadrant(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: WAL format and API changes (9.5) |
| Date: | 2014-11-18 08:47:19 |
| Message-ID: | 546B0797.7030409@vmware.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 11/18/2014 10:28 AM, Michael Paquier wrote:
> Btw, did you do a run with the buffer capture facility and checked for page
> differences?
Yes. That's how I bumped into the bug fixed in c73669c0. That tool has
been tremendously helpful.
> Except that, after going through the code once again, ISTM that the patch
> is in a nice state. It may be better to wait for some input from Andres, he
> may catch some issues I haven't spotted.
Yeah, I'm sure there are tons of small things. I'll have to take a small
break and read through the patch myself after a few days. But I'd like
to get this committed pretty soon. I believe everyone agrees with the
big picture, even if there's some little tweaking left to do. It's a
pain to maintain as a patch, and I believe the FPW compression patch is
waiting for this to land.
- Heikki
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alban Hertroys | 2014-11-18 08:51:14 | Re: [HACKERS] Performance issue with libpq prepared queries on 9.3 and 9.4 |
| Previous Message | Michael Paquier | 2014-11-18 08:32:26 | Re: Incorrect initialization of sentPtr in walsender.c |