From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
---|---|
To: | "Bossart, Nathan" <bossartn(at)amazon(dot)com> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com> |
Subject: | Re: [Proposal] Allow users to specify multiple tables in VACUUM commands |
Date: | 2017-09-29 01:09:11 |
Message-ID: | CAB7nPqR2bn2+u7KU+7=49s0dBhj5SxFpgg2xYcYB6dbb75N6HA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Sep 29, 2017 at 2:44 AM, Bossart, Nathan <bossartn(at)amazon(dot)com> wrote:
> Alright, I've added logging for autovacuum in v23. I ended up needing to
> do a little restructuring to handle the case when the relation was skipped
> because the lock could not be obtained. While doing so, I became
> convinced that LOG was probably the right level for autovacuum logs.
+ if (IsAutoVacuumWorkerProcess() && params->log_min_duration >= 0)
+ elevel = LOG;
+ else if (!IsAutoVacuumWorkerProcess())
+ elevel = WARNING;
+ else
+ elevel = 0;
OK, of course let's not change the existing log levels. This could be
always tuned later on depending on feedback from others. I can see
that guc.c also uses elevel == 0 for some logic, so we could rely on
that as you do.
@@ -116,6 +116,9 @@ analyze_rel(Oid relid, RangeVar *relation, int options,
int elevel;
AcquireSampleRowsFunc acquirefunc = NULL;
BlockNumber relpages = 0;
+ bool rel_lock;
+
+ Assert(relation != NULL);
I can see that this is new in your patch. Definitely adapted.
In short, I am switching it back to "ready for committer". We may want
the locking issues when building the relation list to be settled
first.
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Langote | 2017-09-29 01:23:28 | Re: Partitions: \d vs \d+ |
Previous Message | Tom Lane | 2017-09-29 00:01:37 | Re: Minor codegen silliness in ExecInterpExpr() |