From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Peter Geoghegan <pg(at)heroku(dot)com>, hlinnaka <hlinnaka(at)iki(dot)fi>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: tuplesort_gettuple_common() and *should_free argument |
Date: | 2017-02-01 05:59:58 |
Message-ID: | CAB7nPqQpT68pROGt02Qzz3e+D62212vS=r-20BerXWekqBvKKA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Jan 26, 2017 at 8:16 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> [ in the service of closing out this thread... ]
>
> Peter Geoghegan <pg(at)heroku(dot)com> writes:
>> Finally, 0003-* is a Valgrind suppression borrowed from my parallel
>> CREATE INDEX patch. It's self-explanatory.
>
> Um, I didn't find it all that self-explanatory. Why wouldn't we want
> to avoid writing undefined data? I think the comment at least needs
> to explain exactly what part of the written data might be uninitialized.
> And I'd put the comment into valgrind.supp, too, not in the commit msg.
>
> Also, the suppression seems far too broad. It would for instance
> block any complaint about a write() invoked via an elog call from
> any function invoked from any LogicalTape* function, no matter
> how far removed.
It seems like a new patch will be provided, so moved to next CF with
"waiting on author".
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2017-02-01 06:03:52 | Re: Parallel Append implementation |
Previous Message | Amit Kapila | 2017-02-01 05:58:55 | Re: Parallel Index Scans |