Re: Error check always bypassed in tablefunc.c

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Joe Conway <mail(at)joeconway(dot)com>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Error check always bypassed in tablefunc.c
Date: 2015-01-19 23:47:56
Message-ID: CAB7nPqQcZQ0oSSy6a0KxBqZ80uYSm6oAAStmqSic-5w0166Y2g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Jan 19, 2015 at 11:06 PM, Joe Conway <mail(at)joeconway(dot)com> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 01/19/2015 08:16 AM, Alvaro Herrera wrote:
>> Haven't looked at this patch, but I wonder if it would be better
>> to replace the innards of connectby with a rewrite of the query to
>> use standard WITH queries. Maybe we can remove a couple hundred
>> lines from tablefunc.c?
>
> Seems like a good idea -- connectby is really obsolete for quite a
> while now other than as an SRF example. I guess we only keep it around
> for backwards compatibility?
For master, yes we could brush up things a bit. Now do we really do
the same for back-branches? I would think that the answer there is
something close to the patch I sent.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeff Davis 2015-01-20 00:03:08 Re: PATCH: decreasing memory needlessly consumed by array_agg
Previous Message Michael Paquier 2015-01-19 23:41:51 Re: Fillfactor for GIN indexes