Re: [HACKERS] Cache lookup errors with functions manipulation object addresses

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Aleksander Alekseev <a(dot)alekseev(at)postgrespro(dot)ru>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] Cache lookup errors with functions manipulation object addresses
Date: 2017-11-24 12:13:01
Message-ID: CAB7nPqQWJj6Q0HPwCKiaRvDUBQwhcLn9wCe8RzyKjCR_4aC2_Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On Thu, Aug 10, 2017 at 9:48 AM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> On Wed, Aug 9, 2017 at 2:47 PM, Aleksander Alekseev
> <a(dot)alekseev(at)postgrespro(dot)ru> wrote:
>> I believe this patch is "Ready for Committer".
>>
>> The new status of this patch is: Ready for Committer
>
> Thanks for the lookup, but I think that this is still hasty as no
> discussion has happened about a couple of APIs to get object names.
> Types, operators and functions have no "cache lookup" and prefer
> producing names like "???" or "-". We may want to change that. Or not.
> The current patch keeps existing interfaces as much as possible but
> those existing caveats remain.

Attached is a rebased patch set. Álvaro, as you have introduced most
of the problems with 4464303 & friends dated of 2015 when you
introduced get_object_address(), could you look at this patch set?
--
Michael

Attachment Content-Type Size
0001-Refactor-syscache-routines-to-get-attribute-name.patch application/octet-stream 12.1 KB
0002-Extend-lookup-routines-for-FDW-and-foreign-server-wi.patch application/octet-stream 14.3 KB
0003-Refactor-routines-for-subscription-and-publication-l.patch application/octet-stream 5.7 KB
0004-Eliminate-user-visible-cache-lookup-errors-for-objad.patch application/octet-stream 118.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Etsuro Fujita 2017-11-24 13:03:35 Re: [HACKERS] Add support for tuple routing to foreign partitions
Previous Message Rajkumar Raghuwanshi 2017-11-24 11:30:05 Re: [HACKERS] Parallel Append implementation