Re: forward vs backward slashes in msvc build code

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: forward vs backward slashes in msvc build code
Date: 2015-04-26 00:01:59
Message-ID: CAB7nPqQHoeee0mB1AY1oZVB8+wr28R-5+=k2WzHaJ+vDKcFDSQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Apr 26, 2015 at 2:19 AM, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>
> On 04/25/2015 10:53 AM, Michael Paquier wrote:
>>
>> On Sat, Apr 25, 2015 at 9:58 PM, Peter Eisentraut wrote:
>>>
>>> On 4/24/15 12:22 AM, Michael Paquier wrote:
>>>>
>>>> Now that the stuff related to the move from contrib/ to src/bin/,
>>>> modulescheck and tmp_install has been committed, shouldn't we give a
>>>> new shot at this patch? Attached is a rebased version.
>>>
>>> done
>>
>> Thanks, bowerbird is running fine:
>>
>> http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=bowerbird&dt=2015-04-25%2013%3A31%3A06
>
>
>
> But currawong is not - it runs an older version of the MS build tools. See
> <http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=currawong&dt=2015-04-25%2016%3A31%3A12>:
>
> Bad format filename 'src/backend/access/brin/brin.c'
> at src/tools/msvc/VCBuildProject.pm line 73.
> VCBuildProject::WriteFiles(VC2008Project=HASH(0x9a7274),
> "*Project::F") called at src/tools/msvc/Project.pm line 363
> Project::Save(VC2008Project=HASH(0x9a7274)) called at
> src/tools/msvc/Solution.pm line 539
> Solution::Save(VS2008Solution=HASH(0xc00b7c)) called at
> src/tools/msvc/Mkvcbuild.pm line 656
> Mkvcbuild::mkvcbuild(HASH(0xbed464)) called at build.pl line 36

Oops, attached is a patch that should make currawong happier..
--
Michael

Attachment Content-Type Size
20150426_fixmsvc_fileformat.patch text/x-diff 512 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Joel Jacobson 2015-04-26 00:10:13 Re: PL/pgSQL, RAISE and error context
Previous Message Tom Lane 2015-04-25 22:15:25 Re: Shouldn't CREATE TABLE LIKE copy the relhasoids property?