Re: [BUGS] BUG #13741: vacuumdb does not accept valid password

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, brown(at)fastmail(dot)com, "pgsql-bugs(at)postgresql(dot)org" <pgsql-bugs(at)postgresql(dot)org>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [BUGS] BUG #13741: vacuumdb does not accept valid password
Date: 2015-12-24 00:21:46
Message-ID: CAB7nPqQFQSb_cX7W=GXzHwdejqW=oN0Dc0W2rr2Cc-v+_Zyvxw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On Thu, Dec 24, 2015 at 1:55 AM, Alvaro Herrera
<alvherre(at)2ndquadrant(dot)com> wrote:
> Tom Lane wrote:
>
>> Sorry for having lost track of this. I think if we're going to do this,
>> we should do it now not later, because it essentially reverts the
>> connectDatabase() API change made in 83dec5a71 in favor of a different API
>> change with the same purpose. Now, that doesn't matter if no third-party
>> code is using connectDatabase(), but I have a suspicion that there
>> probably is some. Any such users will not thank us for whacking
>> connectDatabase's API around in 9.5 and then whacking it around
>> differently in 9.6.
>>
>> In short, I think we should apply this now and back-patch into 9.5,
>> like the prior patch, even though we're post-RC1. The reduction in
>> cross-version API churn is worth it.
>>
>> If no objections, I'll go do that shortly.
>
> No objection here.

Thanks for taking care of that!
--
Michael

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message nayaksasmita484 2015-12-24 06:25:52 BUG #13831: Server Closed Connection Unexpectedly
Previous Message Tom Lane 2015-12-23 18:22:51 Re: BUG #13830: pg_table_size and pg_indexes_size

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2015-12-24 00:28:47 Re: pgbench - allow backslash-continuations in custom scripts
Previous Message Caleb Meredith 2015-12-24 00:03:20 Row level security (RLS) for updatable views