On Tue, Dec 9, 2014 at 6:00 PM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
> On 9 December 2014 at 17:17, Michael Paquier <michael(dot)paquier(at)gmail(dot)com> wrote:
>
>>> While re-looking at that. I just found that when selecting the
>>> relations that are reindexed for a schema we ignore materialized view
>>> as the key scan is only done using 'r' as relkind. The patch attached
>>> fixes that.
>> Here is an updated patch doing as well that:
>> - Regression test checking if user has permissions on schema was broken
>> - Silent NOTICE messages of REINDEX by having client_min_messages set
>> to WARINING (thoughts about having a plpgsql function doing
>> consistency checks of relfilenode before and after reindex?)
>
> ISTM that REINDEX is not consistent with VACUUM, ANALYZE or CLUSTER in
> the way it issues NOTICE messages.
>
> I'm inclined to simply remove the NOTICE messages, except when a
> REINDEX ... VERBOSE is requested.
OK. Perhaps that's not worth mentioning in the release notes, but some
users may be used to the old behavior. What about the other issues
(regression test for permissions incorrect and matviews)?
--
Michael