Re: client_connection_check_interval default value

From: Hüseyin Demir <huseyin(dot)d3r(at)gmail(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: client_connection_check_interval default value
Date: 2026-04-06 12:59:49
Message-ID: CAB5wL7aSJ5Cw1VdX5V0L4s3t+T2=M=yXo07sC+JLdKggkLCkdA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

> Thanks for the patch!
>
> Commit 557a9f1e3e6 recently added test for lock stats, which also causes
> lock wait situations. So it seems better to extend that test to cover
> log_lock_waits rather than adding a new TAP test file.
>
> I've prepared a patch to do this. Patch attached. Thought?
>
> Regards,
>

Appreciated for the patch. I reviewed it quickly.

In the test description it says that `still waiting logged exactly once
despite pg_reload_conf() wakeups")` but the test sends via
pg_log_backend_memory_contexts(). It would make sense to update it.

```
- 1, "still waiting logged exactly once despite pg_reload_conf()
wakeups");
+ 1, "still waiting logged exactly once despite wakeups from
pg_log_backend_memory_contexts()");
```

Secondly, before finishing the test it tries to check that no
log_lock_waits messages are emitted. But the comment has the opposite
meaning.

```
- 'check that log_lock_waits message is emitted when the lock is acquired
after waiting'
+ 'check that no log_lock_waits message is emitted when the lock is
acquired after waiting'
```

I'm not sure they need to change but these are the only topics I wanted to
add. Otherwise, lgtm and thanks.

I attached the v3 to convey my ideas. You can use it or update the existing
if you think the suggestions are reasonable.

Regards.

Attachment Content-Type Size
v3-0001-Add-TAP-tests-for-log_lock_waits.patch application/octet-stream 5.1 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dmitry Dolgov 2026-04-06 13:05:37 Re: Extract numeric filed in JSONB more effectively
Previous Message Robert Haas 2026-04-06 12:47:30 Re: pg_plan_advice