Re: Date-time extraneous fields with reserved keywords

From: Joseph Koshakow <koshy44(at)gmail(dot)com>
To: Keisuke Kuroda <kuroda(dot)keisuke(at)nttcom(dot)co(dot)jp>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Date-time extraneous fields with reserved keywords
Date: 2023-03-04 17:29:09
Message-ID: CAAvxfHezhw8G=5qHEnCsZa4rmOS-YPt=5LJD5ZCbvCeLT5j=wg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Attached is the described patch. I have two notes
after implementing it:
- It feels like a bit of an abstraction break to
set tmask without actually setting any fields in
tm.
- I'm not sure if we should hard code in those
three specific reserved keywords or set tmask
in the default case.

Any thoughts?

- Joe Koshakow

Attachment Content-Type Size
v2-0001-Handle-extraneous-fields-in-date-time-input.patch text/x-patch 10.3 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Joel Jacobson 2023-03-04 18:27:05 Re: Missing free_var() at end of accum_sum_final()?
Previous Message Tom Lane 2023-03-04 17:12:41 Re: libpq-fe.h should compile *entirely* standalone