| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Cc: | Greg Burd <greg(at)burd(dot)me>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Add bms_offset_members() function for bitshifting Bitmapsets |
| Date: | 2026-07-08 23:55:48 |
| Message-ID: | CAApHDvrxVejtenPtju9RUt8A8zb-vdr1wu_R7_pQTcmCj6f9VQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, 9 Jul 2026 at 07:24, Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
> In the function test_random_offset_operations(), the variable seed is
> declared as type uint64, then assigned from GetCurrentTimestamp() or
> PG_GETARG_INT64(), both of which return int64, then it is passed to
> pg_prng_seed(), which takes uint64, and then it is printed using
> INT64_FORMAT. Maybe this could be a bit more consistent?
I pushed a change to make seed int64 instead. It's still possible to
specify the full range of possible values that GetCurrentTimestamp()
can (or could ever) return with the int64 type. This way, there's no
longer a mismatch in the format specifier for elog and the type we're
formatting. That's an improvement, so thanks.
David
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2026-07-09 00:02:03 | Re: s/pg_attribute_always_inline/pg_always_inline/? |
| Previous Message | Peter Smith | 2026-07-08 22:54:10 | Re: PSQL - prevent describe listing tables that are already in listed schemas |