| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com>, Greg Burd <greg(at)burd(dot)me> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Add bms_offset_members() function for bitshifting Bitmapsets |
| Date: | 2026-07-08 19:24:51 |
| Message-ID: | 08fa9f01-373e-4cb4-9650-ad20517e2de3@eisentraut.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 20.04.26 01:52, David Rowley wrote:
> On Mon, 20 Apr 2026 at 07:22, Greg Burd <greg(at)burd(dot)me> wrote:
>> I applied, tested, and reviewed these changes. Thanks for doing this, only a few small things jumped out.
>
> Many thanks. I took all of those suggestions.
>
>> SELECT test_bms_offset_members('(b 1)', -2147483648);
>
> I made that one use member 0 instead of 1. That'll mean "new_highest"
> goes to INT_MIN rather than INT_MIN + 1.
In the function test_random_offset_operations(), the variable seed is
declared as type uint64, then assigned from GetCurrentTimestamp() or
PG_GETARG_INT64(), both of which return int64, then it is passed to
pg_prng_seed(), which takes uint64, and then it is printed using
INT64_FORMAT. Maybe this could be a bit more consistent?
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2026-07-08 20:39:42 | Hash index bucket split bug |
| Previous Message | Haibo Yan | 2026-07-08 19:24:22 | [PATCH] ecpg: use memcpy in a few length-based copies |