| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | Teodor Sigaev <teodor(at)sigaev(dot)ru> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: speedup tidbitmap patch: hash BlockNumber |
| Date: | 2014-12-17 05:27:01 |
| Message-ID: | CAApHDvrb8kGdVE31_4-wrKyTXhDBAg3=V=mCxjL2Hu7YRo8_wA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 17 December 2014 at 06:07, Teodor Sigaev <teodor(at)sigaev(dot)ru> wrote:
>
> I think this suggestion is misguided, and the patch itself needs
>> rethinking. Instead of doing this, let's hack dynahash.c itself
>> to substitute a shim like this when it's told function == tag_hash and
>> keysize == sizeof(uint32). Then we can remove any similar shims that
>> already exist, and possibly end up with a net savings of code rather than
>> adding more.
>>
> done, actoually I found oid_hash shim only.
>
>
- hash_ctl.hash = oid_hash; /* a bit more efficient than tag_hash */
+ hash_ctl.hash = tag_hash; /* a bit more efficient than tag_hash */
I think the comment may need removed here.
Regards
David Rowley
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2014-12-17 06:02:03 | Re: pg_basebackup vs. Windows and tablespaces |
| Previous Message | Kyotaro HORIGUCHI | 2014-12-17 03:39:22 | Re: Escaping from blocked send() reprised. |