| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | shihao zhong <zhong950419(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Any reason to keep HEAP_HASOID_OLD? |
| Date: | 2026-10-28 03:13:37 |
| Message-ID: | CAApHDvr50xoFoEjjta8-EUN9D9XAYeosSkMdfe_Nrjy-nXKmmg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, 21 Oct 2026 at 14:39, shihao zhong <zhong950419(at)gmail(dot)com> wrote:
> Patch attached. It removes the define, the doc paragraph about the oid
> field, and everything pageinspect did with it.
>
> The bit is kept as a comment so nobody reuses it.
Thanks for the reminder. I've attached the patch I had pending for
this. I wasn't done and I've not looked at it in a while, but on
comparing to what you've got, you seem to have gone with removing the
pageinspect column. IIRC, I didn't think this was worth breaking any
user code that looks at the column. Instead, I just set it to NULL
always.
I seem to have missed some documentation things, which I'll look at
adjusting soon.
David
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Remove-unused-references-to-HEAP_HASOID_OLD.patch | application/octet-stream | 4.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | jian he | 2026-10-28 03:16:07 | Re: Row pattern recognition |
| Previous Message | Rui Zhao | 2026-10-28 03:11:07 | Re: Use C11 alignas instead of palloc/malloc for alignment |