Re: Compilation issues for HASH_STATISTICS and HASH_DEBUG options

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Compilation issues for HASH_STATISTICS and HASH_DEBUG options
Date: 2025-08-14 14:11:33
Message-ID: CAApHDvqzL4-4s+ih6k8hX3J6KKvVZ-Ht4yVY__ue3SJjuQHKsg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, 15 Aug 2025 at 02:04, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> As I just responded to Hayato-san, I think there's a good case
> for removing the HASH_DEBUG code rather than fixing it (again).

No objections here. It feels like it must not get used very often if
it's taken almost 5 years for someone to notice the warning.

The reason I thought to backpatch the fix was that I was less sure
about removing it in backbranches and thought that should just be
fixed and any consideration to remove it would be in master only.

David

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2025-08-14 14:14:17 Re: cfbot mistakenly reports that a rebase is needed
Previous Message Tom Lane 2025-08-14 14:06:40 Re: [PATCH] bms_prev_member() can read beyond the end of the array of allocated words