| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> |
| Cc: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Fix possible bogus array out of bonds (src/backend/access/brin/brin_minmax_multi.c) |
| Date: | 2022-09-06 01:29:01 |
| Message-ID: | CAApHDvqwFZpgMjUbZv3zZr5Ts9T-qH4GtdB7rM57EK8RG_K+9g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, 6 Sept 2022 at 06:07, Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> wrote:
> I did a search and found a few more places.
> v1 attached.
Thanks. I've done a bit more looking and found a few more places that
we can improve and I've pushed the result.
It feels like it would be good if we had a way to detect a few of
these issues much earlier than we are currently. There's been a long
series of commits fixing up this sort of thing. If we had a tool to
parse the .c files and look for things like a function call to
appendPQExpBuffer() and appendStringInfo() with only 2 parameters (i.e
no va_arg arguments).
I'll hold off a few days before pushing the other patch. Tom stamped
beta4 earlier, so I'll hold off until after the tag.
David
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jonathan S. Katz | 2022-09-06 01:45:48 | Re: pg15b3: recovery fails with wal prefetch enabled |
| Previous Message | Shinya Kato | 2022-09-06 00:54:53 | Re: [PATCH] Tab completion for SET COMPRESSION |