Re: Bug in logical decoding with DDL and subtransactions

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "alvherre(at)kurilemu(dot)de" <alvherre(at)kurilemu(dot)de>, Bingshuai Li <lucian1412(at)outlook(dot)com>, Zhijie Hou <houzhijie22(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Alexander Lakhin <exclusion(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "mark(dot)dilger(at)enterprisedb(dot)com" <mark(dot)dilger(at)enterprisedb(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Andrey Rachitskiy <pl0h0yp1(at)gmail(dot)com>, "a(dot)kozhemyakin(at)postgrespro(dot)ru" <a(dot)kozhemyakin(at)postgrespro(dot)ru>
Subject: Re: Bug in logical decoding with DDL and subtransactions
Date: 2026-10-15 10:34:25
Message-ID: CAApHDvqrbLkc9tk=jCwyV3fMLZ1Tj+b83xpwQxaVG9US-niEGg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, 15 Oct 2026 at 18:25, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> David Rowley <dgrowleyml(at)gmail(dot)com> writes:
> > Do you need to update .abi-compliance-history?
>
> We actually have a bit of a mess here, I think. Our scheme for
> .abi-compliance-history didn't really contemplate overlapping
> ABI-breaking patch series.
>
> At this point, to make the buildfarm happy we need v18's
> .abi-compliance-history to say that 57193b3a0 is the latest reference
> commit. But it would make very little sense to any future software
> archaeologist for the associated text to describe 5eae2800a as the
> cause of the ABI break.
>
> I kind of feel like we need to do this as a straight-up reflection
> of the actual events: v18's .abi-compliance-history should get three
> new entries, citing c7328770b then 5eae2800a then 57193b3a0.

That makes sense. I've attached a patch that adds all 3, but I've left
the reason for the middle one for Álvaro to fill in.

Álvaro, happy for you to fill that part in and push to REL_18_STABLE
once you've prepared the 14..17 versions.

David

Attachment Content-Type Size
0001-Update-.abi-compliance-history-for-struct-ReorderBuf.patch application/octet-stream 1.9 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Matthias van de Meent 2026-10-15 10:41:19 Re: Fix numeric log() with an infinite value and 0<base<=1
Previous Message Japin Li 2026-10-15 10:19:41 Re: Avoid repeated scans of the output buffer in oidvectortypes()