Re: Bug in logical decoding with DDL and subtransactions

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: David Rowley <dgrowleyml(at)gmail(dot)com>
Cc: "alvherre(at)kurilemu(dot)de" <alvherre(at)kurilemu(dot)de>, Bingshuai Li <lucian1412(at)outlook(dot)com>, Zhijie Hou <houzhijie22(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Alexander Lakhin <exclusion(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "mark(dot)dilger(at)enterprisedb(dot)com" <mark(dot)dilger(at)enterprisedb(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Andrey Rachitskiy <pl0h0yp1(at)gmail(dot)com>, "a(dot)kozhemyakin(at)postgrespro(dot)ru" <a(dot)kozhemyakin(at)postgrespro(dot)ru>
Subject: Re: Bug in logical decoding with DDL and subtransactions
Date: 2026-10-15 05:24:52
Message-ID: 1888096.1792041892@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

David Rowley <dgrowleyml(at)gmail(dot)com> writes:
> It's my fault that crake and akepa have been failing the
> abi-compliance-check test for the past week or so. I just pushed a
> commit to fix that, and akepa is still failing due to 5eae2800a.

> Do you need to update .abi-compliance-history?

We actually have a bit of a mess here, I think. Our scheme for
.abi-compliance-history didn't really contemplate overlapping
ABI-breaking patch series.

At this point, to make the buildfarm happy we need v18's
.abi-compliance-history to say that 57193b3a0 is the latest reference
commit. But it would make very little sense to any future software
archaeologist for the associated text to describe 5eae2800a as the
cause of the ABI break.

I kind of feel like we need to do this as a straight-up reflection
of the actual events: v18's .abi-compliance-history should get three
new entries, citing c7328770b then 5eae2800a then 57193b3a0.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Hayato Kuroda (Fujitsu) 2026-10-15 05:26:04 RE: [PATCH] Preserve replication origin OIDs in pg_upgrade
Previous Message Fujii Masao 2026-10-15 05:18:32 Re: [PG19] Promotion hangs behind a backend blocked on a stuck client