Re: Avoid corrupting DefElem nodes when parsing publication_names and publish options

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: assam258(at)gmail(dot)com
Cc: sunil s <sunilfeb26(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Avoid corrupting DefElem nodes when parsing publication_names and publish options
Date: 2026-01-06 04:34:11
Message-ID: CAApHDvqFyY8gCFg7fN9v8R4b6QLshDsYV9y0nLvLjD5Nd4A7LQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, 29 Dec 2025 at 01:18, Henson Choi <assam258(at)gmail(dot)com> wrote:
> - publicationcmds.c: real bug, affects event triggers
> - pgoutput.c: harmless, just API cleanup
>
> The bug in publicationcmds.c is minor in practice—it only affects users who
> have event triggers on publication DDL and use extensions that extract option
> values from pg_ddl_command. This is an uncommon case, but it is a real bug
> nonetheless.
>
> The patch should be applied.

Thank you for doing that analysis. I've followed that and agree with
your conclusion.

I've pushed the patch and backpatched to v14.

David

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2026-01-06 05:38:06 Re: [PROPOSAL] Termination of Background Workers for ALTER/DROP DATABASE
Previous Message Jacob Jackson 2026-01-06 04:24:52 Re: Proposal: Add a UNIQUE NOT ENFORCED constraint