Re: Avoid corrupting DefElem nodes when parsing publication_names and publish options

From: Henson Choi <assam258(at)gmail(dot)com>
To: David Rowley <dgrowleyml(at)gmail(dot)com>
Cc: sunil s <sunilfeb26(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Avoid corrupting DefElem nodes when parsing publication_names and publish options
Date: 2026-01-07 00:26:51
Message-ID: CAAAe_zAJycKWaJA+FqS8aKfs_TO8364BEe+p-2xuvjwi0p75Jw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi David,

Thank you for reviewing and committing the patch.
I appreciate the thorough backport to v14.

2026년 1월 6일 (화) PM 1:34, David Rowley <dgrowleyml(at)gmail(dot)com>님이 작성:

> On Mon, 29 Dec 2025 at 01:18, Henson Choi <assam258(at)gmail(dot)com> wrote:
> > - publicationcmds.c: real bug, affects event triggers
> > - pgoutput.c: harmless, just API cleanup
> >
> > The bug in publicationcmds.c is minor in practice—it only affects users
> who
> > have event triggers on publication DDL and use extensions that extract
> option
> > values from pg_ddl_command. This is an uncommon case, but it is a real
> bug
> > nonetheless.
> >
> > The patch should be applied.
>
> Thank you for doing that analysis. I've followed that and agree with
> your conclusion.
>
> I've pushed the patch and backpatched to v14.
>
> David
>

Thanks to Sunil for the original fix.

Best regards,
Henson

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2026-01-07 00:29:28 Re: Refactor replication origin state reset helpers
Previous Message Jelte Fennema-Nio 2026-01-06 23:49:28 Re: RFC: adding pytest as a supported test framework