| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Compilation issues for HASH_STATISTICS and HASH_DEBUG options |
| Date: | 2025-08-18 23:21:06 |
| Message-ID: | CAApHDvpSMq4CrQ-iwsfhsznKjtB0Xod6o3BngnyoCZPPkWgBSw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, 19 Aug 2025 at 01:34, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> David Rowley <dgrowleyml(at)gmail(dot)com> writes:
> > I've purposefully left references to HASH_DEBUG in the "Original
> > comments" section near the top of dynahash.c. That comment also
> > references function names that no longer exist.
>
> Hm, there is actually no part of that comment para that is accurate
> anymore, so I cannot imagine a reason for leaving it alone. People
> who want to do archaeology can consult the git history. How about
> reducing the para to
>
> * HASH_STATISTICS causes some usage statistics to be maintained,
> * which can be logged by calling hash_stats().
Ok. I pushed it like that. Thanks for looking.
David
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2025-08-18 23:21:20 | Re: Logical Replication of sequences |
| Previous Message | Michael Paquier | 2025-08-18 23:17:29 | Re: Support getrandom() for pg_strong_random() source |